Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox 68 supports {search_url,suggest_url}_get_params in search_provider settings override #25160

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Firefox 68 supports {search_url,suggest_url}_get_params in search_provider settings override #25160

merged 1 commit into from
Nov 22, 2024

Conversation

rebloor
Copy link
Contributor

@rebloor rebloor commented Nov 21, 2024

Summary

The manifest key chrome_settings_overrides search_provider object properties search_url_get_params and suggest_url_get_params were added in Bug 1496075 Support loading search extensions on startup but omitted from the BCD

Test results and supporting details

See https://hg.mozilla.org/mozilla-central/rev/7efb082cc25d#l3.30

Related issues

MDN content changes in TBC

@rebloor rebloor added the data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Nov 21, 2024
@rebloor rebloor requested a review from Rob--W November 21, 2024 02:07
@rebloor rebloor self-assigned this Nov 21, 2024
@github-actions github-actions bot added the size:m [PR only] 25-100 LoC changed label Nov 21, 2024
@rebloor rebloor mentioned this pull request Nov 21, 2024
Merged
caugner
caugner approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

PS: Shouldn't those {search,suggest}_url_{get,post}_params features be subfeatures of {search,suggest}_url?

@caugner caugner changed the title Bug-1496075 Missed search_provider object properties Firefox 68 supports {search_url,suggest_url}_get_params in search_provider settings override Nov 22, 2024
caugner
caugner requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's safe to assume that Chrome also supports these?

webextensions/manifest/chrome_settings_overrides.json Show resolved Hide resolved
webextensions/manifest/chrome_settings_overrides.json Show resolved Hide resolved
@rebloor
Copy link
Contributor Author

rebloor commented Nov 22, 2024

I think it's safe to assume that Chrome also supports these?

@caugner Why, they aren't documented in Chrome's reference content (https://developer.chrome.com/docs/extensions/reference/manifest/chrome-settings-override)

@rebloor
Copy link
Contributor Author

rebloor commented Nov 22, 2024

PS: Shouldn't those {search,suggest}_url_{get,post}_params features be subfeatures of {search,suggest}_url?

@caugner no, they're all simply properties of the manifest key

@Rob--W
Copy link
Member

Rob--W commented Nov 22, 2024

I think it's safe to assume that Chrome also supports these?

@caugner Why, they aren't documented in Chrome's reference content (https://developer.chrome.com/docs/extensions/reference/manifest/chrome-settings-override)

Chrome does not support these. Extensions can put the get parameters in search_url or suggest_url if they want it in a cross-browser way.

Chrome's supported properties are documented at https://source.chromium.org/chromium/chromium/src/+/main:chrome/common/extensions/api/manifest_types.json;l=25-95;drc=636054fd874a8e9535b4db695c8ea15636200e52

@caugner
Copy link
Contributor

caugner commented Nov 22, 2024

Apologies, I drew the wrong conclusions, thanks for clarifying!

@caugner caugner merged commit eff61dc into mdn:main Nov 22, 2024
6 checks passed
@mdn-bot mdn-bot mentioned this pull request Nov 22, 2024
Merged
@rebloor rebloor deleted the Bug-1496075-missed-search_provider-object-properties branch November 22, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rob--W Rob--W Rob--W approved these changes

@caugner caugner caugner approved these changes

Assignees

@rebloor rebloor

Labels
data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions size:m [PR only] 25-100 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rebloor @Rob--W @caugner